[FFmpeg-devel] [PATCH] move cutils string functions to libavutil

[Michael Niedermayer]

Hi

On Fri, Jun 22, 2007 at 06:52:24PM +0200, Michael Niedermayer wrote:
> Hi
> 
> On Fri, Jun 22, 2007 at 03:27:46PM +0200, Benoit Fouet wrote:
[...]
> >  int strstart(const char *str, const char *val, const char **ptr)
> >  {
> > -    const char *p, *q;
> > -    p = str;
> > -    q = val;
> > -    while (*q != '\0') {
> > -        if (*p != *q)
> > -            return 0;
> > -        p++;
> > -        q++;
> > -    }
> > -    if (ptr)
> > -        *ptr = p;
> > -    return 1;
> > +    return av_strstart(str, val, ptr);
> >  }
> 
> dont even think about moving this trash into libavutil!

i think this ended up sounding a little more rude then it was intended
to
what i wanted to say is that the code should be cleaned up and simplified
before moving it into libavutil

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070623/6d48c50b/attachment.pgp>