[FFmpeg-devel] [PATCH] move cutils string functions to libavutil

[Benoit Fouet]

M?ns Rullg?rd wrote:
> Benoit Fouet wrote:
>   
>> Hi,
>>
>> as M?ns suggested, here is an attempt to move some cutils functions to
>> libavutil.
>> once this patch is applied, a second one will come to call those new
>> functions instead of the old ones.
>>     
>
> I don't see anything obviously wrong, but I only had a quick look.
>   

re reading my patch, i found out that the doxy comment i added for
av_pstrcat was not accurate, i changed it

> I'm a bit skeptical to the filename cutils.c though, it being quite
> vague.  Since it contains string manipulation functions, string.c
> would seem a more logical choice.
>
>   

i'm opened to any name :)
if it's ok for string(s).c, i'll go for it, this is just a matter of
file name

>> i hesitated about small_strptime, does it bleong to avutil too ?
>>     
>
> I guess that depends on what it does.
>
>   

it seems to "convert a string representation of time to a time tm
structure" (from man 3 strptime)

new patch attached (still named cutils.c for the moment, but can (and
will) change)

Ben
-- 
Purple Labs S.A.
www.purplelabs.com
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cutils.c.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070622/908fd7a4/attachment.asc>