[FFmpeg-devel] dv_read_seek over 2GB fix

[Roman Shaposhnick]

On Tue, 2007-06-19 at 02:33 +0200, Michael Niedermayer wrote:
> Hi
> 
> On Mon, Jun 18, 2007 at 07:03:41PM +0300, Maksym Veremeyenko wrote:
> > Michael Niedermayer ?????:
> > 
> > >
> > >offset_t url_fseek(ByteIOContext *s, offset_t offset, int whence)
> > >{
> > >[...]
> > >        return AVERROR(EINVAL);
> > >[...]
> > >        offset_t res = AVERROR(EPIPE);
> > >
> > >
> > >>this value re-returned to av_seek_frame that 
> > >>do not care about error code - it's interesting only in sign of returned 
> > >>value from:
> > >
> > >its not relevant if any current code checks for specific errors or just
> > >error vs. no error, the code should properly pass error codes
> > this version of attached patch returns 0 on success or negative error code.
> 
> looks ok (minus the trailing whitespace) but iam not dv maintainer,
> roman is that ...

  Isn't the bigger issue here that AVInputFormat::read_seek() has a
return type that doesn't make much sense with the lfcompile(5) ?

Thanks,
Roman.