[FFmpeg-devel] MPEG-2 Acceleration Refactor

[Diego Biurrun]

On Sat, Jun 16, 2007 at 07:37:02PM -0700, Greg Hulands wrote:
> 
> On 16/06/2007, at 6:52 PM, Michael Niedermayer wrote:
> 
> > On Sat, Jun 16, 2007 at 06:44:21PM -0700, Greg Hulands wrote:
> >> --- mpeg12.c	(revision 9339)
> >> +++ mpeg12.c	(working copy)
> >> @@ -47,25 +47,25 @@
> >> #ifdef CONFIG_ENCODERS
> >> static void mpeg1_encode_block(MpegEncContext *s,
> >> -                         DCTELEM *block,
> >> -                         int component);
> >> +                               DCTELEM *block,
> >> +                               int component);
> >
> > cosmetic
> >
> > note a single cosmetic (whitespace only) change in a patch which  
> > contains
> > functional changes leads to rejection of the patch
> > such changes belong into a seperate patch
> 
> I'm confused. The first patch I submitted today, you rejected because  
> I had used tabs - fair enough. How was the original non-cosmetic code  
> allowed in the repository if one of the first rules of rejection is  
> cosmetics?
> 
> I am using spaces now so I don't know why in the email it looks like  
> the cosmetic problems are still there. Maybe mailmail is doing  
> something. I will attach the file next time round instead of pasting  
> it in.
> 
> So just to clarify for this patch, you don't want me to fix the  
> cosmetic problems with the function prototypes, but all code that I  
> touch, you do?

He wants you to send in a patch without whitespace-only changes.  Feel
free to send in a separate patch for these issues.

Diego