[FFmpeg-devel] [PATCH] imlib2's rgb.txt

[Ramiro Ribeiro Polla]

V?ctor Paesa wrote:
>> Hi,
>>     
>>> Michael Niedermayer wrote:
>>>       
>>>> Hi
>>>>
>>>> On Mon, Jun 11, 2007 at 01:28:31PM -0300, Ramiro Ribeiro Polla wrote:
>>>>
>>>>         
>>>>> Ramiro Ribeiro Polla wrote:
>>>>>
>>>>>           
>>>>>> Michael Niedermayer wrote:
>>>>>>
>>>>>>
>>>>>>             
>>>>>>> Hi
>>>>>>>
>>>>>>> On Mon, Jun 11, 2007 at 09:06:34AM +0200, V?ctor Paesa wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>                 
>>>>>>>>> Attached patch adds another location for the imlib2 vhook to
>>>>>>>>> search
>>>>>>>>> for
>>>>>>>>> rgb.txt.
>>>>>>>>> It's a relative path instead of an absolute path, good for
>>>>>>>>> Windows,
>>>>>>>>> where X11 isn't installed.
>>>>>>>>>
>>>>>>>>> Even though vhooks should go away soon, it's nice for the next
>>>>>>>>> filter
>>>>>>>>> system to support this too, so this patch is also informative for
>>>>>>>>> whoever writes the next imlib2 filter.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>                   
>>>>>>>> The patch is also useful for POSIX systems that don't have X11
>>>>>>>> installed, or
>>>>>>>> have it installed in unusual directories.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>                 
>>>>>>> would it not make more sense to allow the user to specifiy the file
>>>>>>> path?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>>> Yes, it would.
>>>>>> Also, it would make sense to add hex value support like drawtext.
>>>>>>
>>>>>> How about this:
>>>>>> - add -rgb parameter to specify rgb.txt file
>>>>>>
>>>>>>             
>>>> probably ok
>>>>
>>>>
>>>>
>>>>         
>>>>>> - remove the 2 default paths for rgb.txt (ok?)
>>>>>>
>>>>>>             
>>>> i think some default should be kept somewhere
>>>>
>>>>
>>>>
>>>>         
>>>>>> - copy ParseColor (from drawtext.c), or put function in some shared
>>>>>> file. (does lav* have a function for parsing hex colors?)
>>>>>>
>>>>>>
>>>>>>             
>>>>> Answering my own question, ffmpeg.c does that in opt_pad_color.
>>>>> Can it be moved to a library as av_parse_color
>>>>>
>>>>>           
>>>> yes
>>>> though please look at AVOption & av_eval() maybe we can use some of
>>>> that
>>>> code it would be a cool to be able to rather pass an expression which
>>>> would
>>>> change the color over time ...
>>>>
>>>>
>>>>
>>>>         
>>> This is interesting. Used with output_example's video, you get quite a
>>> psychedelic output =).
>>> Patch attached (and then another commit to reindent).
>>>       
>> While you're on it, what about adding the alpha channel too (R,G,B,A)?
>> -A max(255,N) would produce a nice fade in text.
>>     
>
> Oops, I really mean -A min(255,N)
>   

Patch attached =)

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: alpha.diff
Type: text/x-patch
Size: 3773 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070616/ea0cdfde/attachment.bin>