[FFmpeg-devel] remove int readers

[Ronald S. Bultje]

Hi,

On 6/13/07, Benoit Fouet <benoit.fouet at purplelabs.com> wrote:
>
> Ronald S. Bultje wrote:
> >Index: ffmpeg/libavformat/mp3.c
> >===================================================================
> >--- ffmpeg.orig/libavformat/mp3.c    2007-06-05 02:11:13.000000000 -0400
> >+++ ffmpeg/libavformat/mp3.c    2007-06-13 07:22:58.000000000 -0400
> >@@ -406,7 +406,7 @@
> >         buf2 = buf;
> >
> >         for(frames = 0; buf2 < end; frames++) {
> >-            header = (buf2[0] << 24) | (buf2[1] << 16) | (buf2[2] <<
> 8) | buf2[3];
> >+            header = AV_RB32(buf[2]);
> >
>
> buf2, no ?
>
> >Index: ffmpeg/libavformat/rtp.c
> >===================================================================
> >--- ffmpeg.orig/libavformat/rtp.c    2007-06-13 07:13:19.000000000 -0400
> >+++ ffmpeg/libavformat/rtp.c    2007-06-13 07:37:04.000000000 -0400
> >@@ -693,7 +693,7 @@
> >             break;
> >         default:
> >             if(s->parse_packet) {
> >-                rv= s->parse_packet(s, pkt, &timestamp, buf, len);
> >+            rv= s->parse_packet(s, pkt, &timestamp, buf, len);
> >             } else {
> >
>
> tabs are forbidden in svn


Shouldn't be there at all... Leftover from another patchset, apologies.

>Index: ffmpeg/libavformat/ffm.c
> >===================================================================
> >--- ffmpeg.orig/libavformat/ffm.c    2007-06-05 02:11:12.000000000 -0400
> >+++ ffmpeg/libavformat/ffm.c    2007-06-13 07:31:26.000000000 -0400
> >@@ -720,8 +720,7 @@
> >     lseek(fd, 8, SEEK_SET);
> >     read(fd, buf, 8);
> >     pos = 0;
> >-    for(i=0;i<8;i++)
> >-        pos |= (int64_t)buf[i] << (56 - i * 8);
> >+    pos = AV_RB64(buf);
> >
>
> the pos = 0 seems unneeded now too


And the int i and the pos variable in the first place - all removed.

and i also have problem with your patches, they may have a "wrong" mime
> type...


I don't really know how to change it, I'll look for that...

New patch attached, still wrong mimetype. :-/.

Ronald
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-intreaders.patch
Type: application/octet-stream
Size: 9493 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070613/cf8a9fb2/attachment.obj>