[FFmpeg-devel] [PATCH] Re: Reworking the codec lookup system

[Michael Niedermayer]

Hi

On Mon, Jun 11, 2007 at 10:52:38AM +0200, Nicolas George wrote:
> Le tridi 23 prairial, an CCXV, Michael Niedermayer a ?crit?:
> > its hard to define precissely, but something like
> 
> Of course. But the real problem is not to properly define it: anyone working
> with audio-video encoding would understand it. The question is to _decide_
> that it must be so, and that must be done with the full authority of a major
> ffmpeg developer.
> 
> Here is a patch that explicitly documents it in the header.
> 
> Regards,
> 
> -- 
>   Nicolas George
> 
> 
> Index: libavcodec/avcodec.h
> ===================================================================
> --- libavcodec/avcodec.h	(revision 9281)
> +++ libavcodec/avcodec.h	(working copy)
> @@ -44,6 +44,11 @@
>  #define AV_TIME_BASE_Q          (AVRational){1, AV_TIME_BASE}
>  
>  /**
> + * Identifiers of codec families.
> + * Two decoders with the same ID can decode the same streams.
> + * Two encoders with the same ID can encode compatible streams.
> + * For example, encoder_vorbis and encoder_libvorbis both use
> + * CODEC_ID_VORBIS.

our mpeg2 decoder can decode mpeg1 and 2, libmpeg2 can also
and iam sure there are mpeg2 decoders which would refuse mpeg1
and mpeg1 decoders which cant decode mpeg2

also i think calling it "family" is not really clarifying anything


>   *
>   * If you add a codec ID to this list, add it so that
>   * 1. no value of a existing codec ID changes (that would break ABI),
> @@ -2119,8 +2124,22 @@
>   * AVCodec.
>   */
>  typedef struct AVCodec {
> +    /**
> +     * Name of the codec

Name of the codec implementation


[...]
> +    /**
> +     * Type of the codec: audio, video, subtitle, etc.
> +     */
>      enum CodecType type;

redundant

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070611/b56403c5/attachment.pgp>