[FFmpeg-devel] [PATCH] cleanup swscale

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:

> Hello,
> On Fri, Jun 08, 2007 at 09:46:58AM +0200, Luca Barbato wrote:
>> Michael Niedermayer wrote:
>> >> -static inline void yuv2yuvXinC(int16_t *lumFilter, int16_t **lumSrc, int lumFilterSize,
>> >> -                               int16_t *chrFilter, int16_t **chrSrc, int chrFilterSize,
>> >> -                               uint8_t *dest, uint8_t *uDest, uint8_t *vDest, int dstW, int chrDstW)
>> >> +static inline void yuv2yuvXinC(int16_t *lumFilter,
>> >> +                               int16_t **lumSrc, int lumFilterSize,
>> >> +                               int16_t *chrFilter,
>> >> +                               int16_t **chrSrc, int chrFilterSize,
>> >> +                               uint8_t *dest,
>> >> +                               uint8_t *uDest, uint8_t *vDest,
>> >> +                               int dstW, int chrDstW)
>> > 
>> > this is less readable not more than the original code
>> 
>> people using 80col will find the latter more readable.
>
> Then consider putting static inline is a separate line or something like

A common practise is to format functions like this:

static inline void
foo()
{
}

-- 
M?ns Rullg?rd
mans at mansr.com