[FFmpeg-devel] [PATCH] cleanup swscale

[Reimar Döffinger]

Hello,
On Fri, Jun 08, 2007 at 09:46:58AM +0200, Luca Barbato wrote:
> Michael Niedermayer wrote:
> >> -static inline void yuv2yuvXinC(int16_t *lumFilter, int16_t **lumSrc, int lumFilterSize,
> >> -                               int16_t *chrFilter, int16_t **chrSrc, int chrFilterSize,
> >> -                               uint8_t *dest, uint8_t *uDest, uint8_t *vDest, int dstW, int chrDstW)
> >> +static inline void yuv2yuvXinC(int16_t *lumFilter,
> >> +                               int16_t **lumSrc, int lumFilterSize,
> >> +                               int16_t *chrFilter,
> >> +                               int16_t **chrSrc, int chrFilterSize,
> >> +                               uint8_t *dest,
> >> +                               uint8_t *uDest, uint8_t *vDest,
> >> +                               int dstW, int chrDstW)
> > 
> > this is less readable not more than the original code
> 
> people using 80col will find the latter more readable.

Then consider putting static inline is a separate line or something like
this (or the arguments in a separate line with only 4 space
indentation).
I find arranging the arguments in a way that makes sense much, much more
important than making 80cols work - even on a real console you can
usually get more easily.

Greetings,
Reimar D?ffinger