[FFmpeg-devel] [PATCH] Coremake support - ff-dcttest-nommxgpl.patch (1/1)

[Michael Niedermayer]

Hi

On Thu, Jun 07, 2007 at 09:05:03AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> In article <20070521171340.GK16391 at MichaelsNB>,
>  Michael Niedermayer <michaelni at gmx.at> wrote:
> > > In file included from dct-test.c:33:
> > > dsputil.h: In function 'copy_block2':
> > > dsputil.h:688: warning: implicit declaration of function 'ST16'
> > > dsputil.h:688: warning: implicit declaration of function 'LD16'
> > > dsputil.h: In function 'copy_block4':
> > > dsputil.h:699: warning: implicit declaration of function 'ST32'
> > > dsputil.h:699: warning: implicit declaration of function 'LD32'
> > > dct-test.c: In function 'idct248_ref':
> > > dct-test.c:333: warning: implicit declaration of function 'sqrt'
> > > dct-test.c:333: warning: incompatible implicit declaration of built-in 
> > > function 'sqrt'
> > > dct-test.c:334: warning: implicit declaration of function 'cos'
> > > dct-test.c:334: warning: incompatible implicit declaration of built-in 
> > > function 'cos'
> > > dct-test.c:334: error: 'M_PI' undeclared (first use in this function)
> > > dct-test.c:334: error: (Each undeclared identifier is reported only once
> > > dct-test.c:334: error: for each function it appears in.)
> > > dct-test.c:342: warning: incompatible implicit declaration of built-in 
> > > function 'sqrt'
> > > dct-test.c:343: warning: incompatible implicit declaration of built-in 
> > > function 'cos'
> > > dct-test.c:350: warning: incompatible implicit declaration of built-in 
> > > function 'sqrt'
> > > dct-test.c:393: warning: implicit declaration of function 'rint'
> > > dct-test.c:393: warning: incompatible implicit declaration of built-in 
> > > function 'rint'
> > > 
> > > I can work around this by adding an include for math.h.
> 
> And attached is the last patch to fix dct-test. It needs math.h for M_PI 
> and definitions of functions such as sqrt() (normally through 
> HAVE_AV_CONFIG_H, but we're trying without now). Then, it needs 
> CONFIG_GPL/MMX awareness for those of us not using GPL code. Lastly, 
> since we no longer use HAVE_AV_CONFIG_H, the #undef printf can go away.

shouldnt these be in seperate patches ...

[...]

>  #ifdef ARCH_X86
> +  DCT_ERROR("FAAN",            0, ff_faandct,         fdct, FAAN_SCALE),
> +#ifdef HAVE_MMX
>    DCT_ERROR("MMX",             0, ff_fdct_mmx,        fdct, NO_PERM),
>    DCT_ERROR("MMX2",            0, ff_fdct_mmx2,       fdct, NO_PERM),
> -  DCT_ERROR("FAAN",            0, ff_faandct,         fdct, FAAN_SCALE),

FAAN is not x86 specific

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070607/2c816c26/attachment.pgp>