[FFmpeg-devel] [Ffmpeg-devel] [PATCH] Support raw mpegts streams from dvr

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Wed, Jun 06, 2007 at 01:01:11PM +0100, M?ns Rullg?rd wrote:
>> 
>> Wolfram Gloger wrote:
>> >> From: Nico Sabbi <nsabbi at email.it>
>> >> not crucial, but indispensable: think of H264 and mpeg4: they need a
>> >> qualificator in teh pmt
>> >
>> > Ok, for that content Mans' statement may be true.
>> > However, DVB for me still is 99.9% mpeg2video and mp2 audio.
>> 
>> And how do you, in a multiprogram TS, guess which PIDs belong to the same
>> program, and with which PCR PID, without the PMT?
>> 
>> A transport stream without a PMT is no better than an AVI file without
>> a header.  It is *invalid*, 
>
> true
>
>> and we should IMO make no attempt to support
>> such things.  The harder it is to play bad files, the more incentive for
>> people to create them properly in the first place.
>
> i strongly disagree, ffmpegs goal was always to play everything not
> to reject things which are invalid just because they are, if we did
> that ffmpeg wouldnt even play 10% of all AVI files -> ffmpeg would
> have no users and noone would care about it or contribute to it
> it also wouldnt reduce the number of broken avi files, people would
> just use a different player/demuxer
>
> what can and should be done is to print a warning that the file is
> invalid not play big jerk and say "no we wont play this"

You have a valid point.  However, I'd still prefer support for broken
files to be off by default, only enabled by specifying -strict -1 or
something.  Alternatively, we could provide a simple tool to generate
a valid pat/pmt so people could fix their files.

-- 
M?ns Rullg?rd
mans at mansr.com