[FFmpeg-devel] [PATCH] RoQ decoder 4:4:4 update

[Eric Lasota]

Michael Niedermayer wrote:

> what is the advantage of pre unpacking cells to 4:4:4 instead of doing
> it during rendering?
>   

Readability, simplifies vector applications into block copies, 
represents codebook how it will be applied rather than how it's stored.

>> +typedef unsigned char roq_mb2[3][4];
>> +typedef unsigned char roq_mb4[3][16];
>> +typedef unsigned char roq_mb8[3][64];
>>     
>
> these do nothing but obfuscate the code
>   

How so?

> reordering of functions
>   

All of the prototyped functions were replaced.  Do you want them matched 
to the existing prototype order?