[FFmpeg-devel] patch -- grab v4l infastructure

[Michael Niedermayer]

Hi

On Sat, Jun 02, 2007 at 05:04:00AM -0400, mmh wrote:
Content-Description: message body text
> 
> Michael Niedermayer writes:
>  > this looks wrong if desired_palette != -1
> 
> corrected, thanks.
[...]
> @@ -117,15 +131,12 @@
>  
>      desired_palette = -1;
>      desired_depth = -1;
> -    if (ap->pix_fmt == PIX_FMT_YUV420P) {
> -        desired_palette = VIDEO_PALETTE_YUV420P;
> -        desired_depth = 12;
> -    } else if (ap->pix_fmt == PIX_FMT_YUYV422) {
> -        desired_palette = VIDEO_PALETTE_YUV422;
> -        desired_depth = 16;
> -    } else if (ap->pix_fmt == PIX_FMT_BGR24) {
> -        desired_palette = VIDEO_PALETTE_RGB24;
> -        desired_depth = 24;
> +    for (j = 0; j < vformat_num; j++) {
> +      if (ap->pix_fmt == video_formats[j].palette) {
> +	  desired_palette = video_formats[j].palette;

tab and you seem to mix VIDEO_PALETTE_ and PIX_FMT_*

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070602/585295cb/attachment.pgp>