[FFmpeg-devel] [PATCH] List supported video size and rate abbreviations

Michael Niedermayer michaelni
Sat Jun 2 13:38:24 CEST 2007


Hi

On Sat, Jun 02, 2007 at 10:29:01AM +0200, Stefano Sabatini wrote:
> On date Friday 2007-06-01 21:16:25 +0200, Michael Niedermayer encoded:
> > Hi
> > 
> > On Fri, Jun 01, 2007 at 06:13:28PM +0200, Stefano Sabatini wrote:
> > [...]
> > 
> > > Index: ffmpeg.c
> > > ===================================================================
> > > --- ffmpeg.c	(revision 9165)
> > > +++ ffmpeg.c	(working copy)
> > > @@ -2065,12 +2065,27 @@
> > >      av_log_level = atoi(arg);
> > >  }
> > >  
> > > +static void list_video_rate_abvs(void)
> > 
> > what is abvs? if you mean abbreviation thats abbr (try google with both)
> 
> I agree with you, I was conforming to the abbreviation for
> abbreviation (sic! ;-)) choosed in
> libavformat/utils.c:{frame_abvs,AbvEntry}.
> 
> If you prefer I can use "abbr" consistently throughout the patch then
> send a cosmetic patch to change frame_abvs and AbvEntry and the code
> that use them accordingly, or even better send *before* the cosmetic
> patch *then* this one.

AbvEntry and the other non exported abv names should be changed
the order of patches doesnt matter, choose whichever you like best


> 
> [...]
> > > Index: libavformat/avformat.h
> > > ===================================================================
> > > --- libavformat/avformat.h	(revision 9165)
> > > +++ libavformat/avformat.h	(working copy)
> > > @@ -883,6 +883,46 @@
> > >  
> > >  int match_ext(const char *filename, const char *extensions);
> > >  
> > > +
> > > +/**
> > > + * Number of supported video size and rate abbreviations supported.
> > > + */
> > > +extern int const video_size_rate_abv_nb;
> > 
> > would need a av_ or avcodec_ prefix
> 
> OK, then I prefer avcodec_ for consistency with
> avcodec_video_{size,frame}_abv_string.

avcodec in libavformat/avformat.h is not ok, and iam not sure if the
whole should not rather be in libavcodec


> 
> > and iam not completely sure if i like this implementation, somehow i
> > dont ...

what i meant here is that it might make more sense to export a
size and a framerate table directly
with pix_fmt the information which is stored is likely going t change so
directly exporting the table cant be done but here, hell what do you want
to store in a table of abbreviations and width/height?
(and yes the size and framerate tables should be split)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070602/4b870b0f/attachment.pgp>



More information about the ffmpeg-devel mailing list