[FFmpeg-devel] Stack variables alignment check in libavcodec/dsputil.c

matthieu castet castet.matthieu
Mon Jul 30 23:07:24 CEST 2007


Hi,

Roman Shaposhnick wrote:
> Hi,
> 
> On Mon, 2007-07-30 at 22:05 +0200, Alex Beregszaszi wrote:
>> Hi,
>>
>>> does the following code really belong to libavcodec/dsputil.c? Shouldn't
>>> it be moved to configure? Or at least duplicated there as well.
>> I think it is ok to reside there, and anyway, it must be a message
>> printed on runtime imho, to inform the user.
> 
>   Well, I might've agreed with the above statement if we have anything
> in our public header that would depend on that functionality, but it
> seems that once you're done compiling libav* and ffmpeg -- that's it.
> You might never ever use that compiler again.
> 
>   I do agree that printing it in runtime identifies the executable
> as the one with potential problems, but frankly a big WARNING message
> during the configure step would achieve the same result. Warn the one
> who is doing a build and not confuse somebody for whom it too late to
> fix the problem anyway.
> 

And how to you handle cross-compilation stuff where configure test is 
not possible to run ?

Matthieu




More information about the ffmpeg-devel mailing list