[FFmpeg-devel] Patch for folding unaligned access routines into one file

[Roman Shaposhnick]

On Sun, 2007-07-29 at 01:50 +0200, Michael Niedermayer wrote:
> Hi
> 
> On Fri, Jul 27, 2007 at 09:01:09PM -0700, Roman Shaposhnik wrote:
> > Hi
> > 
> > On Sat, 2007-07-28 at 02:04 +0200, Michael Niedermayer wrote:
> > > Hi
> > > 
> > > On Fri, Jul 27, 2007 at 01:40:16PM -0700, Roman Shaposhnick wrote:
> > > > Guys,
> > > > 
> > > > while cleaning up the __GNUC__ thing I've come across one peculiarity: 
> > > > it seems that we've got two sets of pretty much identical routines
> > > > for accessing unaligned data residing in 
> > > >     libavutil/intreadwrite.h
> > > > and libavcodec/bitstream.h. 
> > > > 
> > > > The obvious question now is, should we fold them into one set by
> > > > applying the attached patch?
> > > 
> > > yes but
> > > maybe the folding of calls to stuff from intreadwrite.h / bitstream.h
> > > should be folded in a seperate patch from the folding of the
> > > implementations in *.h
> > 
> >   Let me see if I follow -- you want this to be split in two patches:
> > first one would just move unalignedXX into intreadwrite.h as-is,
> > and the second one would fold the implementation, right?
> 
> no
> 
> 1. replace _use_ of unaligned*() by LD/ST/AV_RB*/...

  Committed.

> 2. fold the implementation

  In flight. Will post an updated patch soon together with performance
data.

Thanks,
Roman.