[FFmpeg-devel] [PATCH] Move H.264 DSP functions from dsputil.c to h264dsp.c

[Panagiotis Issaris]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Niedermayer wrote:
> Hi
> 
> On Sat, Jul 28, 2007 at 08:35:32PM +0200, Panagiotis Issaris wrote:
>> Hi
>>
>> Michael Niedermayer wrote:
>>> Hi
>>>
>>> On Sat, Jul 28, 2007 at 12:40:08PM +0200, Panagiotis Issaris wrote:
>>>   
>>>> Hi,
>>>>
>>>> Panagiotis Issaris wrote:
>>>>     
>>>>>> Michael Niedermayer wrote:
>>>>>>   
>>>>>>     
>>>>>>         
>>>>>>> Hi
>>>>>>>
>>>>>>> On Fri, Jul 27, 2007 at 06:04:18PM +0200, Panagiotis Issaris wrote:
>>>>>>> [...]    
>>>>>>>       
>>>>>>>           
>>>>>>>> Ouch, I just noticed that with this patch I had accidentally moved lots
>>>>>>>> of the H.264 decoder DSP code in a file with a different header,
>>>>>>>> resulting in incorrect "Copyright by ..." lines.
>>>>>>>>
>>>>>>>> Is it okay to just merge the "Copyright by ..." lines? Or would it be
>>>>>>>> better to split the h264dsp.c file right away in a h264dspenc.c and
>>>>>>>> h264dspdec.c as Aurelien suggested?
>>>>>>>>     
>>>>>>>>       
>>>>>>>>         
>>>>>>>>             
>>>>>>> IMHO split if possible
>>>>>>>
>>>>>>> [...]
>>>>>>>   
>>>>>>>     
>>>>>>>       
>>>>>>>           
>>>>>> I'd like to start with renaming h264dsp.c to h264dspenc.c. So that would be:
>>>>>> svn mv h264dsp.c h264dspenc.c and the attached patch. Okay to commit?
>>>>>>
>>>>>>  Makefile  |    2 -
>>>>>>  h264dsp.c |   81
>>>>>> --------------------------------------------------------------
>>>>>>  2 files changed, 1 insertion(+), 82 deletions(-) 
>>>>>>     
>>>>>>         
>>>>> The previous patch would then be followed by this one, which takes care of
>>>>> some renames after the previous pure rename patch.
>>>>>   
>>>>>       
>>>> Next, the attached patch moves the H.264 decoder DSP functions out of dsputil into a separate file called h264dspdec.c.
>>>>     
>>> but these functions are needed by the encoder too ...
>>>
>>>   
>> They aren't yet used in the encoder patch I am working on. Okay to
>> commit it as is for now and migrate them to a file containing
>> common DSP code called "h264dsp.c" once it is actually used from both
>> the encoder and decoder?
> 
> no, move them to the correct file please, or leave them where they
> are


The attached patch moves the common H.264 DSP functions out of dsputil.c
into a separate file called h264dsp.c.

Tested with ./configure --enable-gpl and ./configure --enable-gpl
- --disable-decoder=h264 --disable-encoder=h264

 Makefile  |    4
 dsputil.c |  321 -----------------------------------------
 h264dsp.c |  354 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 360 insertions(+), 319 deletions(-)

With friendly regards,
Takis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGre1w9kOxLuzz4CkRAi1JAJ9J0xqjW0jpXHF1wbO7PXNwMwGklACfd9BR
dZAoT/QG2udwXyds9nwY+fo=
=j2jo
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070730T155201-ffmpeg-dsputil_to_h264dsp3.diff
Type: text/x-patch
Size: 28463 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070730/5daacfe0/attachment.bin>