[FFmpeg-devel] Fixpoint FFT optimization, with MDCT and IMDCT wrappers for audio optimization

[Diego Biurrun]

On Sun, Jul 29, 2007 at 06:00:26PM -0400, Marc Hoffman wrote:
> On 7/29/07, Diego Biurrun <diego at biurrun.de> wrote:
> > On Sun, Jul 29, 2007 at 02:14:19PM -0400, mmh wrote:
> > >
> > > I think I got the integration issues out now.  Thanks for all the great input.
> > >
> > > --- configure (revision 9807)
> > > +++ configure (working copy)
> > > @@ -608,6 +608,7 @@
> > >      v4l2
> > >      x11grab
> > >      zlib
> > > +    fixedpoint
> > >  '
> >
> > Alphabetical order please, also this seems to be unused.
> >
> > > @@ -686,6 +687,7 @@
> > >      sys_soundcard_h
> > >      termios_h
> > >      threads
> > > +    fixedpoint
> > >  "
> >
> > ditto
> >
> > > --- libavcodec/Makefile       (revision 9807)
> > > +++ libavcodec/Makefile       (working copy)
> > > @@ -358,6 +358,10 @@
> > >  OBJS-$(CONFIG_VP6F_DECODER)            += i386/vp3dsp_mmx.o i386/vp3dsp_sse2.o
> > >  endif
> > >
> > > +ifeq ($(HAVE_FIXEDPOINT),yes)
> > > +OBJS += fft_fixedpoint.o
> > > +endif
> >
> > This can be done in one line like all the other entries in the Makefile.
> >
> > I don't quite understand what CONFIG_FIXEDPOINT/HAVE_FIXEDPOINT is
> > supposed to do, you're not setting the variable anywhere and thus it
> > will not find its way into config.mak and make will not compile the
> > file ...
> 
> I set it by hand with configure --enable-fixedpoint.
> 
> which created the following
> 
> mmh at yoda$ grep FIXEDPOINT config.mak config.h
> config.mak:HAVE_FIXEDPOINT=yes
> config.mak:CONFIG_FIXEDPOINT=yes
> config.h:#define HAVE_FIXEDPOINT 1
> config.h:#define ENABLE_FIXEDPOINT 1
> config.h:#define CONFIG_FIXEDPOINT 1
> config.h:#define ENABLE_FIXEDPOINT 1
> mmh at yoda$

OK, this will work of course, but you forgot to add the option to the
--help output.

CONFIG_FIXEDPOINT is enough, it's what we use for things that can be
individually enabled and disabled.

Diego