[FFmpeg-devel] Reenabling OS/2

[Dave Yeo]

On Mon, 23 Jul 2007 12:30:00 +0200, Diego Biurrun wrote:

>On Sun, Jul 22, 2007 at 05:48:16AM -0700, Dave Yeo wrote:
>> Hi, doing a svn pull of ffmpeg last night and attempting to build I
>> discovered that OS/2 support had been pulled. I guess due to lack of
>> bugs as it was building here with just a couple of minor fixes needed.
>> Here is a patch to reenable the OS/2 build. I have only supported gcc
>> 3.3.5 (klibc063) and currently shared builds do not run due to DLL
>> naming issues.
>> This patch does not include various fixes needed for the old EMX build
>> system but I doubt that anyone would use it to build ffmpeg.
>> In the future I will try to file bugs if the build needs any tweeking.
>
>OS/2 support was broken and in lack of a maintainer, therefore it was
>axed.  Are you willing to look after it?

I will attempt to. I may need help from the list with things like
fixing the shared build without adding much to the makefiles.

>
>> --- ffmpeg.svn/configure	Sat Jul 21 23:32:16 2007
>> +++ ffmpeg/configure	Sun Jul 22 04:52:22 2007
>> @@ -1182,17 +1185,38 @@ case $targetos in
>>    irix*)
>>      targetos=irix
>>      ranlib="echo ignoring ranlib"
>>      ;;
>> -  *)
>> +   os/2)
>
>indentation messup
>
>> +    TMPE=$TMPE".exe"
>
>Hmmmm, this is necessary?

Looks like EXESUF=".exe" is all that is needed

>
>> +    pkg_requires=""
>
>Huh?  This should not be necessary.

Ok, this was just pulled from the last working configure I had here and
did not know why some of this was included. New patch attached. ffmpeg
and ffplay (using sdl) build and run and pass the limited testing I
have done here though only static build.
Also note that the only os2 things in the code now are in
libavcodec/makefile for os2threads.c, libavcodec/os2threads.c and
libavutil/internal.h for not doing rip-relative addressing.
I would also suggest changing the changelog to something like "OS/2 EMX
support dropped" as most of the other OS/2 specific code was for the
older and unmaintained EMX libc which has most likely been broken for
building ffmpeg for quite a while but was unnoticed as most people are
using the newer klibc (a fork of EMX with the GPL parts replaced by
various *BSD code or rewriiten under the LGPL originally for IBMs
benefit).
klibc currently resides at http://svn.netlabs.org/libc 
Dave
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/octet-stream
Size: 1394 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070723/cd193727/attachment.obj>