[FFmpeg-devel] [PATCH] Proper support for building MSVC import libraries

[Ramiro Ribeiro Polla]

Diego Biurrun wrote:
> On Thu, Jul 19, 2007 at 06:36:14PM -0300, Ramiro Polla wrote:
>   
>> IMO, Makefile commands don't belong in configure (such as 
>> SLIB_INSTALL_EXTRA_CMD).
>>     
>
> I disagree.  I moved it to configure so that all system-specific
> settings are decided and set inside configure without affecting the
> Makefiles.
>
>   

Then how about we move install-lib-shared from common.mak into a 
one-line variable in configure too? All that symlinking and version 
number after the file name non-sense are system-specific for UNIX. It's 
wrong for MinGW.

(yes, I am being sarcastic)

I agree they should not be ifeq'd in the Makefiles like they used to be. 
That was ugly. But a Makefile command should not be entirely in 
configure. It is also ugly. Look at all the backslashes for special 
symbols. And the - sign before the command. Why does configure have to 
care about Makefile syntax?

Now look at BUILD_SHARED and BUILD_STATIC. Why doesn't configure just 
export INSTLIBTARGETS with the appropriate targets? Because that's a 
proper way of separating configure stuff from Makefile stuff.

What I propose to clean all this is to put Makefile commands in the 
Makefiles. If it's unacceptably ugly for Unix users to look at any 
Windows specific stuff in a Makefile, then just separate it into 
something like common_win32.mak. It won't be code duplication, just 
separation. To make a proper import lib target. There are some more 
stuff wrong for MinGW ATM. I am trying to clean MinGW32 support. It is 
ugly as is. It's hard to maintain since all MinGW specific stuff (hacks) 
are enclosed in one section in configure.

I know this will face fierce opposition, as it always does, but I am 
trying to clean it up, so, bear with me here...

Ramiro Polla