[FFmpeg-devel] [PATCH 2/9] Replace AVERROR_UNKNOWN by AVERROR(EINVAL)

[Panagiotis Issaris]

Op 19-jul-07, om 18:01 heeft Michael Niedermayer het volgende  
geschreven:

> Hi
>
> On Thu, Jul 19, 2007 at 05:53:32PM +0200, Panagiotis Issaris wrote:
>> Hi
>>
>> Op 19-jul-07, om 17:43 heeft Michael Niedermayer het volgende
>> geschreven:
>>
>>> On Thu, Jul 19, 2007 at 02:55:17PM +0200, Panagiotis Issaris wrote:
>>>> The attached patch replaces the only occurrance of AVERROR_UNKNOWN
>>>> with
>>>> AVERROR(EINVAL).
>>>
>>> AVERROR_UNKNOWN "unknown error" !=
>>> EINVAL "Invalid argument"
>>
>> Currently, in the ffmpeg sourcecode it is :)
>
> i know but changing all AVERROR_UNKNOWN to EINVAL is wrong as it
> discards information about the true meaning of the code
> they should rather individually and manually be changed to the correct
> E*

You are right. I'll have a look tonight how to change 'em.  
Furthermore, there
will probably be errors which are not nicely expressible using the  
standard
error names: I'd think it would be best to add error codes for  
specific multimedia
related errors?

With friendly regards,
Takis
--
vCard: http://issaris.org/pi.vcf
PGP key: http://issaris.org/pi.key