[FFmpeg-devel] [RFC] SDP Generation

[Luca Abeni]

Hi Michael,

Michael Niedermayer wrote:
[...]
>>> please check that 10 + c->extradata_size * 2 doesnt overflow
>> I think I did:
>> - "; config=" is 9 characters
>> - extradata is encoded in extradata_size * 2 characters
>> - then there is the \0 at the end
>> Am I missing something?
> 
> yes, lets assume extradata_size is INT_MAX
> INT_MAX*2 + 10 is 8 or so, your extradate encoding overflows the buffer

Sorry, I misunderstood your comment. I see the problem now.
Fixing it right now...


			Thanks,
				Luca