[FFmpeg-devel] [PATCH] split png.c

[Michael Niedermayer]

Hi

On Tue, Jul 17, 2007 at 02:30:34PM +0200, Diego Biurrun wrote:
> On Tue, Jul 17, 2007 at 02:16:12PM +0200, Baptiste Coudurier wrote:
> > 
> > Attila Kinali wrote:
> > > On Sun, 15 Jul 2007 17:12:46 +0100
> > > M?ns Rullg?rd <mans at mansr.com> wrote:
> > > 
> > >> I'd like to apply this.  Objections?
> > > 
> > > Would it be possible to call the header file lavc_png.h or 
> > > something similar? png.h clashes with the global header file
> > > of libpng which is placed in /usr/include. This already caused
> > > compile problems in MPlayer[1] and i'm sure it will cause problems
> > > for other projects too.
> > 
> > Sorry but Im against this, png.h is internal header and is not meant to
> > be included from any project directly. IMHO Mplayer is faulty here.
> 
> It isn't.  The build system just looked in libavcodec/ before looking in
> /usr/include.

what about putting internal and exported headers into seperate directories
in ffmpeg svn ?
that would solve this i think
also it might simplify installation of the exported headers and draw a
clear line between what is supposed to be used and what not by applications


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070717/625d3727/attachment.pgp>