[FFmpeg-devel] [PATCH 01/10] zlib decoder

[Måns Rullgård]

Vadim Lebedev <vadim at mbdsys.com> writes:

>>>>+static void
>>>>+copy_bytes(uint8_t *dst, uint8_t *src, unsigned int len)
>>>>+{
>>>>+    while (len--)
>>>>+        *dst++ = *src++;
>>>>+}
>>>>      
>>>i think we have such a copy routine somewhere already, but i dont remember
>>>where
>>
>>Reimar said it looked familiar too.  Wherever it is, it's not in a
>>central location.  Where would be the appropriate place for a function
>>like this?
>>
> Why don't you simply use memcpy in this case?

Because memcpy() has undefined behaviour if the source and destination
overlap.

-- 
M?ns Rullg?rd
mans at mansr.com