[FFmpeg-devel] [PATCH 01/10] zlib decoder

[Reimar Döffinger]

Hello,
On Sun, Jul 15, 2007 at 09:37:42PM +0100, M?ns Rullg?rd wrote:
> Aurelien Jacobs <aurel at gnuage.org> writes:
> > On Sun, 15 Jul 2007 21:12:21 +0100
> > Mans Rullgard <mans at mansr.com> wrote:
> >> ---
> >>  libavcodec/Makefile  |    1 +
> >>  libavcodec/inflate.c |  844 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >>  libavcodec/inflate.h |   80 +++++
> >>  3 files changed, 925 insertions(+), 0 deletions(-)
> >>  create mode 100644 libavcodec/inflate.c
> >>  create mode 100644 libavcodec/inflate.h
> >> 
> >> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
> >> index e1685fe..e1f444a 100644
> >> --- a/libavcodec/Makefile
> >> +++ b/libavcodec/Makefile
> >> @@ -27,6 +27,7 @@ OBJS= bitstream.o \
> >>        opt.o \
> >>        bitstream_filter.o \
> >>        audioconvert.o \
> >> +      inflate.o \
> >
> > I would prefer if this was not compiled un-conditionally.
> > Adding inflate.o only for the codecs which require it would be better.
> > (but that can be changed later if you prefer)
> 
> Or we could install inflate.h and make this part of the public API.

IMO it should not be part of the libavcodec public API, it does not
really have much to do with codecs...
Which indirectly also leads to the question: What do you think, how
complicated and how desirable would it be to move the bitstream stuff to
libavutil?

Greetings,
Reimar D?ffinger