[FFmpeg-devel] [PATCH] raw_read_header fix

[Michael Niedermayer]

Hi

On Sat, Jul 14, 2007 at 01:44:51PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > Hi
> >
> > On Sat, Jul 14, 2007 at 01:03:41PM +0100, M?ns Rullg?rd wrote:
> >> Alex Beregszaszi <alex at rtfs.hu> writes:
> >> 
> >> > Hi,
> >> >
> >> >> > Sure, but can you concentrate on the initial question? Can you fix this
> >> >> > issue in a way you prefer? Running seektest on ulaw/alaw (which is
> >> >> > enabled by default) causes division by zero.
> >> >> 
> >> >> yes i can fix it but i wont, iam too lazy, i just review patches ...
> >> >> and the ones posted didnt look good
> >> >
> >> > In that case I do not care anymore on this.  It is not a fair way if you
> >> > could fix this in 5 minutes, but let us dig it hours long and submit
> >> > patches which get of course rejected.
> >
> > i dont claim to be fair, i just claim to reject bad patches
> 
> To avoid a repeat, could you please in the future at least give some
> hint as to how things should be fixed?

i try, always did, i failed here iam not disagreeing about that
if something i say in a review looks incomplete or is unclear, just ask ...

also there are cases where i simply dont know the correct solution, in
these cases i cant do anything except rejecting what looks bad ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070714/6a145556/attachment.pgp>