[FFmpeg-devel] [PATCH] And yet some more __MINGW32__ #ifdefs...

[Diego Biurrun]

On Sat, Jul 14, 2007 at 01:37:16PM +0200, Michael Niedermayer wrote:
> 
> On Sat, Jul 14, 2007 at 12:03:58PM +0200, Alex Beregszaszi wrote:
> > 
> > > > Ok for me, also this code should be moved to libavutil (av_tempfile) or
> > > > completely removed.
> > > 
> > > IMO the latter. A library has no business creating files, at least not
> > > unless explicitly told so. If a file is necessary there should be a way
> > > to pass a file handle something like that.
> > 
> > This is used for some crappy xvid 2pass support.
> 
> what about disabling xvid 2pass support until xvid is fixed to not depend
> on temp files? (yes am evil and trying to force them to cleanup their code,
> feel free to flame me)

Seconded.  FFmpeg should not be a place for such hacks.

Diego