[FFmpeg-devel] [PATCH] proper avcodec_get_context_defaults2

[Michael Niedermayer]

Hi

On Fri, Jul 13, 2007 at 02:27:22PM +0200, Alex Beregszaszi wrote:
> Hi,
> 
> > > avcodec_get_context_defaults2 forgots to set codec_type and leaves it
> > > set to zero (=CODEC_TYPE_VIDEO), while CODEC_TYPE_UNKNOWN is set to -1
> > > in the enumeration.
> > > 
> > > Without this I experienced breakage on some Ogg files (Annodex), which
> > > have unhandled data streams before the video, thus these are selected.
> > > This might be a problem for other demuxers aswell.
> > > 
> > > This patch fixes this issue.
> > 
> > patch ok if regression tests pass
> 
> Well, if they don't pass, there must be some bad assumptions in some
> formats which have to be fixed. Right?

probably but that then would have to be fixed before applying the patch

regression tests should always pass

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070713/a336aa33/attachment.pgp>