[FFmpeg-devel] [PATCH] move av_codec_get_tag to libavformat/utils.c

[Aurelien Jacobs]

On Wed, 11 Jul 2007 11:21:06 +0100 (BST)
M?ns Rullg?rd <mans at mansr.com> wrote:

> Aurelien Jacobs wrote:
> > Hi,
> >
> > Currently, compilation of libavformat fails when configured with the
> > following parameters:
> >
> > ./configure --disable-muxers --disable-parsers --disable-demuxers
> > --disable-encoders --disable-decoders --disable-bsfs
> >
> > Here is the error:
> >
> > libavformat/libavformat.a(utils.o): In function `av_write_header':
> > libavformat/utils.c:2093: undefined reference to `av_codec_get_tag'
> >
> > av_codec_get_tag() is defined in riff.c which is compiled conditionally.
> > This is wrong anyway. A function which is part of public API must
> > be included un-conditionally.
> >
> > Solution 1: move av_codec_get_tag() into utils.c (see attached patch)
> > Is it OK ?
> 
> If av_codec_get_tag() is moved, av_codec_get_id() should move too.  Also,
> Michael has previously said that AVCodecTag should be publicly opaque.

OK. Attached patch should be better.

> > Solution 2: makes compilation of riff.c un-conditional (ugly but simple)
> 
> Please don't do that.

OK.

Aurel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: av_codec_get_tag_id.diff
Type: text/x-diff
Size: 3138 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070711/b1a7b6ff/attachment.diff>