[FFmpeg-devel] [PATCH] move av_codec_get_tag to libavformat/utils.c

Aurelien Jacobs aurel
Wed Jul 11 11:31:49 CEST 2007


Currently, compilation of libavformat fails when configured with the
following parameters:

./configure --disable-muxers --disable-parsers --disable-demuxers
--disable-encoders --disable-decoders --disable-bsfs

Here is the error:

libavformat/libavformat.a(utils.o): In function `av_write_header':
libavformat/utils.c:2093: undefined reference to `av_codec_get_tag'

av_codec_get_tag() is defined in riff.c which is compiled conditionally.
This is wrong anyway. A function which is part of public API must
be included un-conditionally.

Solution 1: move av_codec_get_tag() into utils.c (see attached patch)
Is it OK ?

Solution 2: makes compilation of riff.c un-conditional (ugly but simple)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: av_codec_get_tag.diff
Type: text/x-diff
Size: 2741 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070711/121f577d/attachment.diff>

More information about the ffmpeg-devel mailing list