[FFmpeg-devel] [PATCH] Some cleanups for libavcodec/alac.c

[Michael Niedermayer]

Hi

On Tue, Jul 10, 2007 at 03:34:06PM +0200, Vitor Sessak wrote:
> Hi
> 
> Michael Niedermayer wrote:
> >Hi
> >
> >On Tue, Jul 10, 2007 at 05:54:01AM +0200, Vitor Sessak wrote:
> >[...]
> >> > i think its safer to check the validity of 
> >> setinfo_max_samples_per_frame
> >>>before storing it into the struct
> >>>also *ptr++ looks fine to me
> >>I also like *ptr++, but I think to mix with bytestream_get_be?? it is 
> >>slightly less clear than bytestream_put_byte. But I'm not radical about 
> >>that. New patch attached.
> >
> >i prefer *ptr++ as it also forces the reader to realize that bytestream_*
> >does nothing else then read/write and increase ...
> 
> Ok, patch attached. As I said, I'm not radical about it.

ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070710/34a0f638/attachment.pgp>