[FFmpeg-devel] [PATCH] makes compilation of h263.c conditionnal

[Aurelien Jacobs]

On Tue, 10 Jul 2007 18:30:32 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> Hi
> 
> On Tue, Jul 10, 2007 at 04:56:49PM +0200, Aurelien Jacobs wrote:
> > Hi,
> > 
> > I'm almost done with my effort about making h263.c compilation conditionnal.
> > I have only 2 dependencies left which I would like to remove.
> > 
> > * svq1dec.c uses mvtab which is defined in h263data.h but don't depend
> > on h263 otherwise. Possible solutions:
> >     - makes svq1dec.o depends on h263.o (ugly :-( )
> >     - move mvtab in another file, but I've no idea where. Any suggestion ?
> 
> move it into a new file maybe?

Well, that might be an option. But as a reminder, here is how mvtab
looks like:

const uint8_t mvtab[33][2] =
{
  {1,1}, {1,2}, {1,3}, {1,4}, {3,6}, {5,7}, {4,7}, {3,7},
  {11,9}, {10,9}, {9,9}, {17,10}, {16,10}, {15,10}, {14,10}, {13,10},
  {12,10}, {11,10}, {10,10}, {9,10}, {8,10}, {7,10}, {6,10}, {5,10},
  {4,10}, {7,11}, {6,11}, {5,11}, {4,11}, {3,11}, {2,11}, {3,12},
  {2,12}
};

I'm not sure that creating a new file just for this small array is
a so good idea...
I think that for now I will simply make svq1dec.o depends on h263.o.
That can be improved later anyway.

> > * h261dec.c uses init_vlc_rl() which is define in h263.c but don't depend
> > on h263 otherwise. Possible solutions:
> >     - makes h261dec.o depends on h263.o (ugly :-( )
> >     - move init_vlc_rl() in mpegvideo.c along with init_rl().
> >       Is this acceptable (see attached patch) ?
> 
> ok

Applied.

Aurel