[FFmpeg-devel] [PATCH] matroska subtitle tracks support

[Michael Niedermayer]

Hi

On Tue, Jul 10, 2007 at 01:29:11PM +0200, Aurelien Jacobs wrote:
> On Tue, 10 Jul 2007 11:01:48 +0100 (BST)
> M?ns Rullg?rd <mans at mansr.com> wrote:
> 
> > 
> > Aurelien Jacobs wrote:
> > > On Tue, 10 Jul 2007 10:41:46 +0100 (BST)
> > > M?ns Rullg?rd <mans at mansr.com> wrote:
> > >
> > >>
> > >> Michael Niedermayer wrote:
> > >> > Hi
> > >> >
> > >> > On Mon, Jul 09, 2007 at 11:11:59PM +0200, Aurelien Jacobs wrote:
> > >> >> On Mon, 9 Jul 2007 18:22:18 +0200
> > >> >> Michael Niedermayer <michaelni at gmx.at> wrote:
> > >> >>
> > >> >> > Hi
> > >> >> >
> > >> >> > On Mon, Jul 09, 2007 at 03:47:21PM +0200, Aurelien Jacobs wrote:
> > >> >> > > Hi,
> > >> >> > >
> > >> >> > > I want to apply the attached patch which provide support for Matroska
> > >> >> > > subtitle tracks.
> > >> >> > > Before applying it I wanted to be sure if it is OK to add
> > >> >> > > CODEC_ID_TEXT_SUBTITLE ?
> > >> >> >
> > >> >> > what is TEXT ?
> > >> >> > is it raw  ASCII? raw UTF8? raw plain text (with some encoding specified
> > >> >> > somehow)?
> > >> >>
> > >> >> I intended it to be raw UTF8, but that indeed needs to be clarified.
> > >> >> CODEC_ID_TEXT_UTF8_SUBTITLE seems clear enough to me. OK ?
> > >> >
> > >> > id call it CODEC_ID_PLAIN_TEXT_SUBTITLE with a comment saying that it is
> > >> UTF8
> > >> > currently but we might add a text_encoding field in the future specifying
> > >> > the format
> > >>
> > >> I'd call it simply CODEC_ID_TEXT.  That it usually happens to be subtitle
> > >> text is completely irrelevant.

well its relevant as a CODEC_ID should have only 1 codec_type and a
hypotetical video made by, lets say aalib should have codec_type=video not
subtitle
though of course we can call that TEXT_VIDEO or ASCII_VIDEO then ...


> > >
> > > Indeed, I agree with this. So maybe CODEC_ID_PLAIN_TEXT ?
> > 
> > "PLAIN" differentiating it from what?  If we wanted an ID for, say, HTML
> > I'd suggest CODEC_ID_HTML etc.  When no ambiguity exists, shorter names
> > should be preferred.  This is not Java.
> 
> That's fine with me. If Michael is ok, I will use CODEC_ID_TEXT.

well, iam not opposed to CODEC_ID_TEXT though i still feel that
SUBTITLE should be part of the name but i am fine with CODEC_ID_TEXT
too if you prefer

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070710/a8e471a6/attachment.pgp>