[FFmpeg-devel] [PATCH] matroska subtitle tracks support

Aurelien Jacobs aurel
Tue Jul 10 11:05:11 CEST 2007


On Tue, 10 Jul 2007 10:49:35 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> Hi
> 
> On Mon, Jul 09, 2007 at 11:11:59PM +0200, Aurelien Jacobs wrote:
> > On Mon, 9 Jul 2007 18:22:18 +0200
> > Michael Niedermayer <michaelni at gmx.at> wrote:
> > 
> > > Hi
> > > 
> > > On Mon, Jul 09, 2007 at 03:47:21PM +0200, Aurelien Jacobs wrote:
> > > > Hi,
> > > > 
> > > > I want to apply the attached patch which provide support for Matroska
> > > > subtitle tracks.
> > > > Before applying it I wanted to be sure if it is OK to add
> > > > CODEC_ID_TEXT_SUBTITLE ?
> > > 
> > > what is TEXT ?
> > > is it raw  ASCII? raw UTF8? raw plain text (with some encoding specified
> > > somehow)?
> > 
> > I intended it to be raw UTF8, but that indeed needs to be clarified.
> > CODEC_ID_TEXT_UTF8_SUBTITLE seems clear enough to me. OK ?
> 
> id call it CODEC_ID_PLAIN_TEXT_SUBTITLE with a comment saying that it is UTF8
> currently but we might add a text_encoding field in the future specifying
> the format

I like this plan. I will do it this way unless someone objects.

Aurel




More information about the ffmpeg-devel mailing list