[FFmpeg-devel] [PATCH] moves ff_set_mpeg4_time to mpegvideo_enc.c

[Michael Niedermayer]

Hi

On Mon, Jul 09, 2007 at 03:16:10PM +0200, Aurelien Jacobs wrote:
> On Fri, 6 Jul 2007 10:44:55 +0200
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > Hi
> > 
> > On Fri, Jul 06, 2007 at 01:51:20AM +0200, Aurelien Jacobs wrote:
> > > Hi,
> > > 
> > > The attached patch moves ff_set_mpeg4_time to mpegvideo_enc.c because
> > > it is only used by this file. This allows to make the function static.
> > > Moreover this function is used for mpeg1/2 as well as mpeg4 so it
> > > definitely don't belong in h263.c and it really deserve a renaming
> > > (as suggested by the FIXME comment).
> > > 
> > > Is it OK ?
> > 
> > well ...
> > 
> > the function should be split, some of the things are needed for all
> > b frame encodings some are mpeg4 specific, later belong in h263.c
> > not mpegvideo*.c unless you split mpeg4 out of h263.c ...
> 
> I'm not sure of what you mean exactly. The only mpeg4 specific thing
> in this function is the call to ff_mpeg4_init_direct_mv().
> I now moved it out of the function (see attached patch). Tell me
> if that's what you mean.

the only thing in this function which is not mpeg4 specific is
pb_time and pp_time and they are also almost not used outside
mpeg4

calling the function set_mpeg_time() is TOTALLY wrong, its mpeg4
specific, just out of convenience some non mpeg4 code also used
these variables
that is motion estimation and error resilience uses pb_time and pp_time
to find the distance between frames ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070709/a6541474/attachment.pgp>