[FFmpeg-devel] Getting rid of codec_get_{bmp,wav}_{id,tag}()

[Benoit Fouet]

M?ns Rullg?rd wrote:
> Benoit Fouet wrote:
>   
>> M?ns Rullg?rd wrote:
>>     
>>> Benoit Fouet wrote:
>>>
>>>       
>>>> M?ns Rullg?rd wrote:
>>>>
>>>>         
>>>>> Benoit Fouet wrote:
>>>>>
>>>>>
>>>>>           
>>>>>> M?ns Rullg?rd wrote:
>>>>>>
>>>>>>
>>>>>>             
>>>>>>> Mans Rullgard <mans at mansr.com> writes:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>>>>> Here follows a patch sequence that gets rid of the deprecated
>>>>>>>> codec_get_{bmp,wav}_{id,tag}() functions.
>>>>>>>>
>>>>>>>> There's still more cleanup to do in that area, but this is a start.
>>>>>>>>
>>>>>>>> Please comment.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>                 
>>>>>>> I forgot to mention that regression tests pass equally well before and
>>>>>>> after.  That is, codectest and libavtest pass, while seektest fails in
>>>>>>> the same way.
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>>> i have no problem on seektest, could you elaborate ?
>>>>>>
>>>>>>
>>>>>>             
>>>>> I get a huge diff that reorders lots of lines.  The actual values seem
>>>>> to be correct though.  Reimar has seen the same thing.
>>>>>
>>>>>
>>>>>           
>>>> you mean that values are correct but reordered, that's it ?
>>>>
>>>>         
>>> At a glance, that's what it looks like.
>>>
>>>
>>>       
>> i attach the result of the following command:
>> $ ls tests/data/a-* tests/data/b-* | sort
>>
>> if you want to compare with yours...
>>     
>
> I'm at work now, but the number and names of files are consistent
> with what I recall from running the tests.
>
> It's the output of seektest that for some reason gets reordered.
>   

the only reason i saw for that would be that the sort command used in
seek test script wouldn't return the same thing for you (and Reimar) and
for me.

-- 
Ben
Purple Labs S.A.
www.purplelabs.com