[FFmpeg-devel] Killing AVFrac

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Sun, Jul 08, 2007 at 04:21:57PM +0100, M?ns Rullg?rd wrote:
>> Attached patch is an attempt to remove use of AVFrac.  It works, apart
>> >from audio timestamps occasionally being off by one.  Can anyone see
>> what might be causing the difference?
>
> well the code in ffmpeg.c does convert to double before the divide and:

But are the values computed there used for anything other than
comparisons?  From a quick glance it didn't seem like they were
assigned as actual timestamps.

>> @@ -2177,7 +2175,7 @@ static int compute_pkt_fields2(AVStream *st, AVPacket *pkt){
>>  
>>  //    av_log(NULL, AV_LOG_DEBUG, "av_write_frame: pts2:%"PRId64" dts2:%"PRId64"\n", pkt->pts, pkt->dts);
>>      st->cur_dts= pkt->dts;
>> -    st->pts.val= pkt->dts;
>> +    st->pts.num= pkt->dts * st->pts.den;
>>  
>>      /* update pts */
>>      switch (st->codec->codec_type) {
>
> is also not what it was, that said iam not saying the code makes sense as it
> is currently

Well, there is the den/2 bias thing...  What's the purpose of that
anyway?

-- 
M?ns Rullg?rd
mans at mansr.com