[FFmpeg-devel] Making FFmpeg C99 again. Take II.

[Michael Niedermayer]

Hi

On Sat, Jul 07, 2007 at 02:01:47PM -0700, Roman Shaposhnik wrote:
> Michael,
> 
> I tried to take care of all the comments you made. Please take
> a look at the attached patch.

[...]

> Index: ffmpeg/libavcodec/rv10.c
> ===================================================================
> --- ffmpeg/libavcodec/rv10.c	(revision 9522)
> +++ ffmpeg/libavcodec/rv10.c	(working copy)
> @@ -539,43 +539,34 @@
>      s->h263_long_vectors= ((uint8_t*)avctx->extradata)[3] & 1;
>      avctx->sub_id= AV_RB32((uint8_t*)avctx->extradata + 4);
>  
> -    switch(avctx->sub_id){
> -    case 0x10000000:
> +    if (avctx->sub_id == 0x10000000) {
>          s->rv10_version= 0;
>          s->low_delay=1;
> -        break;
> -    case 0x10002000:
> +    }
> +    else if (avctx->sub_id == 0x10002000) {

please use 
} else if ... { 
like the rest of te file and libav*


[...]
> -        break;
> -    case 0x10003001:
> +    }
> +    else if (avctx->sub_id == 0x10003001) {
>          s->rv10_version= 3;
> +    }
> +    else if (    avctx->sub_id == 0x20001000
> +             || (avctx->sub_id >= 0x20100000 && avctx->sub_id < 0x201a0000)) {
>          s->low_delay=1;

this does not look correct, low_delay=1 seems to get lost 


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070707/8f75c3ed/attachment.pgp>