[FFmpeg-devel] [PATCH] VC-1 MMX DSP functions

[Zuxy Meng]

Hi,

2007/7/7, Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sat, Jul 07, 2007 at 09:21:43PM +0800, Zuxy Meng wrote:
> > 2007/7/7, Christophe GISQUET <christophe.gisquet at free.fr>:
> > > infernix a ?crit :
> > > > This breaks compilation on Debian Etch x86_64. I'm unsure if this is
> > > > expected behavior though.
> > >
> > > I have no 64bits machine to test it on, so your reports are welcome.
> > >
> > > > /tmp/ccaopxZe.s:25763: Error: `0(%rdx,%ecx)' is not a valid base/index
> > > > expression
> > >
> > > int where long int should be used. This probably was in the first patch,
> > > but I forgot to reinsert a cast when refactoring vc1dsp_mmx.c.
> >
> > long only works for LP64; intptr_t is safer.
>
> I think we currently support more systems without intptr_t than non-LP64 systems
> so I don't think this is a good suggestion.

Well, for this particular patch long is OK. But eventually it has to
be fixed; and for those without intptr_t we can provide one.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6