[FFmpeg-devel] ffplay is missing avcodec_thread_free()

[Michael Niedermayer]

Hi

On Fri, Jul 06, 2007 at 05:12:02PM +0200, Benoit Fouet wrote:
> Michael Niedermayer wrote:
> > Hi
> >
> > On Fri, Jul 06, 2007 at 04:01:17PM +0200, Andreas ?man wrote:
> >   
> >> Hi
> >>
> >> Benoit Fouet wrote:
> >>     
> >>> Hi,
> >>>
> >>> Janne Grunau wrote:
> >>>       
> >>>> On Thursday 28 June 2007 18:57:54 Michael Niedermayer wrote:
> >>>>   
> >>>>         
> >>>>> Hi
> >>>>>
> >>>>> why not put the avcodec_thread_free() call in avcodec_close() ?
> >>>>>     
> >>>>>           
> >>>> as attached patch?
> >>>>
> >>>>         
> >>> i don't think ENABLE_THREADS is useful
> >>>
> >>>       
> >> More importantly, if an application already calls avcodec_thread_free()
> >> this patch will (most likely) crash the application,
> >> as pointed out by Thorsten in a previous mail in this thread.
> >>     
> >
> > then set thread_opaque to NULL in avcodec_thread_free()
> >
> > [...]
> >
> >   
> 
> is the attached patch ok for that ?
> (i looked into *thread.c and this is the only file not using av_freep())

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070706/e493af01/attachment.pgp>