[FFmpeg-devel] OS/2?

[Diego Biurrun]

On Fri, Jul 06, 2007 at 12:10:15PM +0200, Michael Niedermayer wrote:
> 
> On Fri, Jul 06, 2007 at 10:31:30AM +0200, Diego Biurrun wrote:
> > On Wed, Jul 04, 2007 at 10:52:07PM +0200, Michael Niedermayer wrote:
> > > 
> > > On Wed, Jul 04, 2007 at 04:11:10PM -0300, Ramiro Ribeiro Polla wrote:
> > > > 
> > > > --- configure	(revision 9470)
> > > > +++ configure	(working copy)
> > > > @@ -1184,27 +1181,6 @@
> > > >      targetos=irix
> > > >      ranlib="echo ignoring ranlib"
> > > >      ;;
> > > > -  os/2)
> > > > -    TMPE=$TMPE".exe"
> > > > -    ar="emxomfar -p128"
> > > > -    ranlib="echo ignoring ranlib"
> > > > -    strip="echo ignoring strip"
> > > > -    add_cflags "-Zomf"
> > > > -    FFLDFLAGS="-Zomf -Zstack 16384 -s"
> > > > -    SHFLAGS="-Zdll -Zomf"
> > > > -    FFSERVERLDFLAGS=""
> > > > -    LIBPREF=""
> > > > -    LIBSUF=".lib"
> > > > -    SLIBPREF=""
> > > > -    SLIBSUF=".dll"
> > > > -    EXESUF=".exe"
> > > > -    osextralibs=""
> > > > -    pkg_requires=""
> > > > -    dv1394="no"
> > > > -    ffserver="no"
> > > > -    vhook="no"
> > > > -    os2="yes"
> > > > -    ;;
> > > 
> > > this looks fairly clean to me so IMHO it could be kept, but its mans decission
> > 
> > Clean or not, it is cruft.  I'm against keeping cruft around.
> 
> its needed for os2 so its not more cruft than macos and beos specific code
> anyway iam not configure maintainer ...

We don't support Mac OS < 10, never have AFAIK, Mac OS X and Darwin work
fine.  BeOS works in one of its many incarnations, for the others you
need to add a POSIX header to your system AFAIK.

> > > > --- Changelog	(revision 9470)
> > > > +++ Changelog	(working copy)
> > > > @@ -89,6 +89,7 @@
> > > >  - codebook generator
> > > >  - RoQ video encoder
> > > >  - QTRLE encoder
> > > > +- OS/2 support removed
> > > >  
> > > > --- libavcodec/Makefile	(revision 9470)
> > > > +++ libavcodec/Makefile	(working copy)
> > > > @@ -318,7 +318,6 @@
> > > >  
> > > >  OBJS-$(HAVE_PTHREADS)                  += pthread.o
> > > >  OBJS-$(HAVE_W32THREADS)                += w32thread.o
> > > > -OBJS-$(HAVE_OS2THREADS)                += os2thread.o
> > > >  OBJS-$(HAVE_BEOSTHREADS)               += beosthread.o
> > > >  
> > > >  OBJS-$(HAVE_XVMC_ACCEL)                += xvmcvideo.o
> > > 
> > > iam against removing os2thread.c
> > > the file does no harm IMHO
> > > removing it might cause some poor guy to waste his time reimplementing
> > > it
> > 
> > IMO it is extremely unlikely that somebody will do that and furthermore
> > even if we keep the file lying around, does that really reduce the
> > chance that work will be duplicated?  The file does not merely have to
> > exist, people need to be aware of its existence.  A notice in the
> > changelog that states this fact should be much more effective.
> 
> nonsense, anyone who tries to add os2 support will either grep for os2
> in all files or none, only a complete idiot would just grep the changelog
> for it. actually i thinks its more likely a person would grep *.{c,h}
> and thus miss the changelog if they search for os2 related code than
> grep just the changelog ...

Better idea: We have a platform-specific section in the documentation.
We can add a note there.  If somebody cannot be bothered to read or grep
that - tough luck.

> and as said, removed files rot quicker, noone will update them if there are
> API changes, ...

This also makes API changes harder since there are more files to
update...

Diego