[FFmpeg-devel] [PATCH] ffmpeg.c -me option implemented as an AVOption

[Michael Niedermayer]

Hi

On Thu, Jul 05, 2007 at 03:12:56PM +0200, Stefano Sabatini wrote:
> Hi all,
> 
> I spent some time trying to understand how the AVOption system works,
> and now there is a patch which simplifies ffmpeg.c, replacing
> opt_motion_estimation with an AVOption setting (operated by
> opt_default).
> 
> Named values for -me_method are now supported in a simpler and cleaner
> way through the AVOption system.
> 
> One problem is that the patch is *not backward compatile*, since it
> changes the OptionDef option "me" with the predefined "me_method"
> AVOption defined in libavcodec/utils.c.
> 
> If you think this is a problem I can modify the patch in order to
> support the old option name with something as:
> 
> {"me", "set motion estimation method (deprecated, use me_method insted)", 
>  OFFSET(me_method), FF_OPT_TYPE_INT, ME_EPZS, INT_MIN, INT_MAX, V|E, "me_method"},
> 
> in libavcodec/utils.c:options.

yes, please add this but under #if LIBAVCODEC_VERSION_INT < ... so that it
automatically disapears with the next major version bump


> 
> BTW: I noted that there are many OptionDef options in ffmpeg.c which
> can be implemented as AVOptions ones, resulting in simpler code. Is it
> OK to change them in this way too?

yes (note dont forget the regression tests)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070705/907e4268/attachment.pgp>