[FFmpeg-devel] [PATCH] Re: Color corruption and seeking errors with H264 disc sources

[Andreas Öman]

Hello,

Michael Niedermayer wrote:
> Hi
> 
> On Tue, Jul 03, 2007 at 01:32:07PM +0200, Andreas ?man wrote:
>> Andreas ?man wrote:
>>> Hi
>>> I basically did two things.
>> ... and basically, i did not send the patch. Here it is.
> 
> this patch contains several unrelated changes please split them
> its impossible to benchmark the bugfix if its mixed with optimizations
> 

Okay, i've done my homework, split them up and run some more detailed
benchmarks.

I've then applied qmul.diff and qplookup.diff and run tests
on these optimizations.

Then i fixed the actual bug in secondqp.diff

So, these three patches needs to be applied in that order.

try#1 is the same benchmark with the bugfix but without the
optimizations (the patch i sent earlier)

The diff between the svn and secondqp median is in the 0.1-0.3%
range if i'm not mistaken. So i believe it's quite okay.

Anyway, this is my last shot at this right now, i'd rather
focus on the h264-multithreading performance issues thats
left.

Aladin.mpg (10 runs)

svn           avg: 3.213  stddev: 0.009  med: 3.214
qmul.diff     avg: 3.207  stddev: 0.005  med: 3.206
qplookup.diff avg: 3.209  stddev: 0.015  med: 3.204
secondqp.diff avg: 3.214  stddev: 0.010  med: 3.216
try#1         avg: 3.223  stddev: 0.015  med: 3.220

SVT.ts clip (10 runs)

svn           avg: 5.298  stddev: 0.016  med: 5.308
qmul.diff     avg: 5.315  stddev: 0.021  med: 5.308
qplookup.diff avg: 5.284  stddev: 0.009  med: 5.280
secondqp.diff avg: 5.320  stddev: 0.052  med: 5.316
try#1         avg: 5.344  stddev: 0.010  med: 5.344

ffh264_issue3.h264 (5 runs)

svn           avg: 26.366  stddev: 0.055  med: 26.390
qmul.diff     avg: 26.292  stddev: 0.035  med: 26.298
qplookup.diff avg: 26.153  stddev: 0.020  med: 26.150
secondqp.diff avg: 26.315  stddev: 0.034  med: 26.298
try#1         avg: 26.421  stddev: 0.023  med: 26.422

apple zodiac trailer (5 runs 2000 frames)

svn           avg: 34.731  stddev: 0.068  med: 34.726
qmul.diff     avg: 34.691  stddev: 0.041  med: 34.694
qplookup.diff avg: 34.748  stddev: 0.064  med: 34.774
secondqp.diff avg: 34.796  stddev: 0.057  med: 34.778
try#1         avg: 34.954  stddev: 0.026  med: 34.958


-------------- next part --------------
A non-text attachment was scrubbed...
Name: qmul.diff
Type: text/x-patch
Size: 1544 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070705/66cfbd32/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qplookup.diff
Type: text/x-patch
Size: 8612 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070705/66cfbd32/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: secondqp.diff
Type: text/x-patch
Size: 19502 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070705/66cfbd32/attachment-0002.bin>