[FFmpeg-devel] [PATCH] move some bitstream related functions

Aurelien Jacobs aurel
Thu Jul 5 15:02:56 CEST 2007


On Thu, 5 Jul 2007 13:24:35 +0200
Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Hello,
> On Thu, Jul 05, 2007 at 12:08:50PM +0200, Aurelien Jacobs wrote:
> > The attached patch moves some bitstream related functions from mpegvideo_enc.c
> > to bitstream.c. Those functions are used by other encoders which don't
> > depend on mpegvideo_enc.c otherwise (such as svq1.c and h263.c).
> > So moving them will then allows me to ensure mpegvideo_enc.c is compiled
> > only when necessary (and not as soon as any encoder is enabled).
> > 
> > Is it ok ?
> 
> Don't know, but including dsputil.h in bitstream.c seems quite ugly to
> me...

Slightly ugly, but that's needed for ff_zigzag_direct.
Maybe ff_zigzag_direct should be moved in another file ?
But I have no idea where it could be moved...

Aurel




More information about the ffmpeg-devel mailing list