[FFmpeg-devel] [PATCH]pes packetizer

[Diego Biurrun]

On Thu, Jul 05, 2007 at 02:25:07PM +0800, realsun wrote:
> Diego Biurrun wrote:
> >On Tue, Jul 03, 2007 at 03:35:38PM +0800, realsun wrote:
> >  
> >>+/**
> >>+ * Find the most fit stream to be muxed.
> >
> >I don't understand.
> 
> i means that is to find the stream which should be muxed into PES stream

Then I would suggest

  Find the stream to mux into the PES stream.

> >>+ * @param[in] flush   whether we flush after every single subtitle 
> >>packet for subtitle
> >
> >I don't understand.
> 
> for subtitle, a single PES packet must be generated, so we set this flag 
> to flush after every single packet

my suggestion:

  Flush after every single subtitle packet.

> >>+ * @param[out] best_i       the best fit stream index
> >
> >I don't understand.
> 
> stream with this index that should be muxed

index of stream to be muxed
  
> >>+/**
> >>+ * Get how many frames is muxed.
> >
> >I don't understand.
> 
> Get total frames that have been muxed

how about

  Get total number of frames that have been muxed.


some comments on the new version below ..

> --- mpeg_pes.h	(revision 0)
> +++ mpeg_pes.h	(revision 0)
> @@ -0,0 +1,157 @@
> +/**
> + * @file mpeg_pes.h
> + * MPEG PES packetizer api header.

API, stray period

> +/**
> + * mux type for PES

muxer?

> +/**
> + * PES Context

context

> +/**
> + * Finalization of PES mux.

muxer

> +/**
> + * Find which stream is most appropriate be muxed.

I cannot parse this sentence.

Diego