[FFmpeg-devel] [PATCH] search for external lib support when no codec found
Benoit Fouet
benoit.fouet
Wed Jul 4 10:39:22 CEST 2007
Michel Bardiaux wrote:
> Benoit Fouet wrote:
>
>> Ismail D?nmez wrote:
>>
>>> On Wednesday 04 July 2007 11:06:34 Michel Bardiaux wrote:
>>>
>>>
>>>> M?ns Rullg?rd wrote:
>>>>
>>>>
>>>>> Benoit Fouet <benoit.fouet at purplelabs.com> writes:
>>>>>
>>>>>
>>>>>> Benoit Fouet wrote:
>>>>>>
>>>>>>
>>>>>>> Benoit Fouet wrote:
>>>>>>>
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> this patch modifies ffmpeg.c so that when it doesn't find a codec for
>>>>>>>> what's been asked, it looks for an external support...
>>>>>>>> it looks for the same string in the codec name + the "lib" prefix
>>>>>>>>
>>>>>>>>
>>>>>>> note that "liba52" should be renamed to work "properly" with "ac3" as
>>>>>>> codec input
>>>>>>> maybe something like "libac3a52" or something like that...
>>>>>>>
>>>>>>>
>>>>>> any comments on that ?
>>>>>>
>>>>>>
>>>>> Still won't solve aac -> libfaad.
>>>>>
>>>>>
>>>> And IMHO any solution that *does* solve that, should explain what it
>>>> does with a big fat message. ffmpeg has enough inscrutabilities as it is.
>>>>
>>>>
>>> Or just revert that meaningless change, meh.
>>>
>>>
>>>
>> this change makes sense, even if everybody doesn't agree...
>> whether a format is supported internaly or by an external lib is now
>> clearer.
>> maybe a naming convention for external libs could be used, like
>> specifying codec in the libxxx name
>>
>>
> Once again, I dont really care whether the change goes or not. But I
> *do* object to changing the value of a (possibly) user-specified option
> without a message at AV_LOG_ERROR level at least.
>
>
i think we heard you already :)
--
Ben
Purple Labs S.A.
www.purplelabs.com
More information about the ffmpeg-devel
mailing list