[FFmpeg-devel] [PATCH] split mpegvideo.c

[Diego Biurrun]

On Tue, Jul 03, 2007 at 08:57:43AM +0200, Benoit Fouet wrote:
> Diego Biurrun wrote:
> > On Wed, Jun 27, 2007 at 10:30:27PM +0200, Benoit Fouet wrote:
> >   
> >> here is a first attempt to $subj
> >>
> >> --- libavcodec/Makefile	(revision 9447)
> >> +++ libavcodec/Makefile	(working copy)
> >> @@ -67,6 +67,7 @@
> >>  OBJS-$(CONFIG_EIGHTBPS_DECODER)        += 8bps.o
> >> +OBJS-$(CONFIG_ENCODERS)                += mpegvideo_enc.o
> >
> > This should really be CONFIG_MPEGVIDEO_ENCODER or similar.
> 
> mpegvideo.o is unconditionnal, i thought mpegvideo_enc.o should be as
> generic as possible too...
> i'm not sure it would work properly with CONFIG_MPEG1VIDEO_ENCODER or
> something like that.
> 
> but, as always, i'm here to learn !
> if you have such a solution in mind, please let me know

OK, hmmm.  I think it's fine to commit this with CONFIG_ENCODERS for the
moment, I don't want to hold up your patch for too long.  After that we
could try to find out what depends on mpegvideo_enc.o and handle the
dependencies through configure.

Diego