[FFmpeg-devel] [Patch] QT RLE encoder, bis

[Benoit Fouet]

Michael Niedermayer wrote:
> Hi
>
> On Sat, Jun 30, 2007 at 10:54:11AM +0200, Alexis Ballier wrote:
>   
>>>> +    /* We will use it to compute the best bulk copy sequence */
>>>> +    uint8_t bulkcount;
>>>> +    /* This will be the number of pixels equal to the preivous frame 
>>>>         
>>> one's
>>>       
>>>> +     * starting from the ith pixel */
>>>> +    uint8_t skipcount;
>>>> +    /* This will be the number of consecutive equal pixels in the 
>>>>         
>>> current
>>>       
>>>> +     * frame, starting from the ith one also */
>>>> +    uint8_t repeatcount;
>>>>         
>>> these should be int or unsigend int not uint8_t, which might be very slow 
>>> on
>>> RISC architectures which lack 8bit registers/operations besides load/store
>>>       
>> Didnt know that, updated
>>     
>
> looks ok
>
>   

Applied

> and after this is applied, maybe you want to add rate distortion optimal
> encoding support
> that is minimize number_of_bits*constant + sum_of_squared_differences instead
> of just number_of_bits
>
> [...]
>   

Ben
-- 
Purple Labs S.A.
www.purplelabs.com