[Ffmpeg-devel] [PATCH] Reduce number of warnings in snow.c

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Thu, Jan 25, 2007 at 12:15:39AM +0100, Michael Niedermayer wrote:
>> 
>> On Wed, Jan 24, 2007 at 03:10:32PM +0100, Panagiotis Issaris wrote:
>> > 
>> > The attached patch brings the number of warnings from 33 to 16 by:
>> >   * suggest parentheses around && within ||
>> 
>> not ok
>
> Why?  Note that I don't mean to question this decision, I'm just
> interested in the reasons.

Any fool knows that && has higher precedence than ||.  Adding
parenthesis only makes the code harder to read.

-- 
M?ns Rullg?rd
mru at inprovide.com