[Ffmpeg-devel] [PATCH]BMP encoder

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Tue, Jan 23, 2007 at 01:08:33PM +0100, Michel Bardiaux wrote:
>> 
>> -- 
> [...]
>
>> Index: libavcodec/bmp.c
>> ===================================================================
>> --- libavcodec/bmp.c	(revision 7659)
>> +++ libavcodec/bmp.c	(working copy)
>> @@ -1,6 +1,7 @@
>>  /*
>>   * BMP image format
>> - * Copyright (c) 2005 Mans Rullgard
>> + * Copyright (c) 2005 Mans Rullgard (decoder)
>> + * Copyright (c) 2006, 2007 Michel Bardiaux (encoder)
>>   *
>>   * This file is part of FFmpeg.
>>   *
>> @@ -32,10 +33,8 @@
>>  #define BMP_RLE4      2
>>  #define BMP_BITFIELDS 3
>
> these should be an enum IMHO, mans any objections if i change that?

Change it if you like.

[...]

> better put the encoder into its own file

Yes, please.

>> +    n_bytes = n_bytes_image + 14 /* BITMAPFILEHEADER */ + 40 /* BITMAPINFOHEADER */;
>
> instead of commenting i would rather use named values 
> (#define BM_FILE_HEADER_SIZE 14)

I prefer macros.

-- 
M?ns Rullg?rd
mru at inprovide.com